1a3f655009
Use NULL for second gettimeofday(2) argument; ok deraadt@ kettenis@
2019-08-09 22:52:13 +00:00
df69c215c7
When system calls indicate an error they return -1, not some arbitrary
...
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
2019-06-28 13:32:41 +00:00
3ffd98f9e9
Xr inetd as a hint about what flavor of crazy you're dealing with
2017-05-25 20:27:55 +00:00
358ea70d4c
Pull in <sys/time.h> for gettimeofday()
...
ok deraadt@
2016-08-26 08:44:04 +00:00
c9899b11e3
More "(<blah> *)0" -> NULL, avoiding any stdarg functions.
...
Feedback millert@ kettenis@
2016-03-16 15:41:10 +00:00
ab2dae90a7
pledge(2) for talkd(8):
...
rpath: fopen(3) _PATH_UTMP in read mode
wpath/cpath: fopen(3) full_tty in write mode (w), which implies O_CREAT
inet/dns: the intervening hosts in the conversation may be remote, or not, but
since we will never know beforehand then it'll always need inet and dns to
resolve the hostnames
ok jca@ and also discussed with tb@
2016-02-05 10:13:51 +00:00
f652621fab
Remove unused headers and sort the remaining
...
OK tb@
2016-02-01 07:25:51 +00:00
64eefbd50f
rename internally to ntalkd, after the binary; this way both
...
"man talkd" and "man ntalkd" work;
issue reported by sobrado; fix from schwarze
2015-11-25 11:21:34 +00:00
cacf1700bc
remove mlinks for aliases: ntalkd, mfs, updatedb
...
ok schwarze
2015-11-21 19:35:19 +00:00
b9fc9a728f
Replace <sys/param.h> with <limits.h> and other less dirty headers where
...
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)
2015-01-16 06:39:28 +00:00
12bc606974
remove .Tn; from Jan Stary <hans at stare dot cz>
2015-01-15 19:06:31 +00:00
205f21369c
do not need a cast from void *
2014-10-08 02:10:05 +00:00
369bef3a14
obvious .Pa fixes; found with mandocdb(8)
2014-01-21 03:15:44 +00:00
4207a9b65a
unsigned char for ctype
...
ok okan kettenis
2013-11-27 21:25:24 +00:00
c5f52c81cd
do not mix concepts of gettimeofday(), tv_sec, and localtime() in a
...
useless fashion.
2013-04-17 17:40:53 +00:00
043fbe51c1
rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
...
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms
2009-10-27 23:59:19 +00:00
9490d37cb6
convert to new .Dd format;
2007-05-31 19:19:00 +00:00
10d9ecc2da
do not name FILE * variables "fd" since it is confusing
2006-10-18 21:18:59 +00:00
4a2f257b6c
fix a few off-by-ones; from NetBSD; ok deraadt@
2006-03-17 08:23:14 +00:00
9723d6b11a
Use queue macros instead of directly accessing fields. ok millert@ pat@
...
deraadt@
2005-10-14 15:39:19 +00:00
f58a73dff3
Avoid use after free(), slight optimization. From Patrick Latifi.
...
ok tom@ deraadt@
2004-11-09 14:50:53 +00:00
adbf56d754
spacing
2004-08-08 19:32:45 +00:00
c9d21d9720
spaces
2004-03-10 04:32:45 +00:00
ec6c8ee6d0
close file on error paths. from Patrick Latifi
2004-03-10 03:45:24 +00:00
b5e17218f0
spaces
2003-07-29 18:38:35 +00:00
c258a5d64c
simple protos
2003-06-26 07:53:26 +00:00
6bcb9e8317
ansi cleanup; ok ian markus
2003-06-11 14:24:46 +00:00
e33d3bd3b8
Remove the advertising clause in the UCB license which Berkeley
...
rescinded 22 July 1999. Proofed by myself and Theo.
2003-06-02 19:34:12 +00:00
b68d276f00
avoid size_t -> int conversion. style nit for sizeof(). David Krause
2002-11-25 07:40:09 +00:00
e296701d5e
sa_family on wire is network byteorder. from Alexander Yurchenko <grange@rt.mipt.ru>
2002-10-08 02:53:54 +00:00
d74953b628
- "resposne" is used without initialization, so zero-fill
...
- sendto(2) performed with osockaddr, so avoid that
- reject anything other than AF_INET
based on patch from xs@kittenz.org . deraadt/millert ok
2002-09-25 03:43:20 +00:00
25f32b489e
Allocate vis_user on the stack instead of using malloc(). This
...
way we don't have to worry about malloc() failure. Also closes
a memory leak since vis_user was never free()d. Lack of malloc()
checking pointed out by Peter Werner.
2002-09-24 17:36:53 +00:00
71fc4cb248
use socklen_t more; henning ok
2002-09-06 19:43:54 +00:00
5d5c76edbf
typos/grammar/better words
...
in comments.
2002-07-07 08:54:50 +00:00
32b1573fff
add a missing newline to an error message.
...
from Jean-Francois Brousseau <krapht@secureops.com >
ok deraadt@
2002-07-03 16:59:05 +00:00
74040066d1
o Use *_FILENO defines instead of numbers
...
o Kill sockt global, it is not needed
o Use STDOUT_FILENO as the 1st arg to sendto().
Previously we used sockt in sendto() which only worked because a) globals
are intialized to 0 and b) inetd sets up fds 0-2 dup'd to the same thing
so it didn't matter that we were sending to stdin, not stdout.
2002-06-21 02:28:32 +00:00
b049587c67
Fix last commit.
2002-05-22 20:16:17 +00:00
6f199a933a
Fix some ut_line manipulation pointed out by Moritz Jodeit.
...
Fixes from Theo and myself.
2002-05-22 20:01:28 +00:00
ffb1448af2
typo; moritz@jodeit.org
2002-05-22 19:07:43 +00:00
52b755013a
whack sprintf
2002-05-22 00:33:39 +00:00
527d29657c
strlcpy sprinkling
2002-05-22 00:32:27 +00:00
9c047b49fc
KNF
2002-05-21 23:51:28 +00:00
78359a7b9b
KNF
2002-05-16 12:16:16 +00:00
4af80cab53
Fix gethostname() usage.
...
deraadt@ ok
2002-02-19 18:38:01 +00:00
c72b5b24e1
Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
2002-02-16 21:27:05 +00:00
50d2b6517b
kill more registers;
...
millert@ ok
2001-12-07 18:45:32 +00:00
a5553e71e1
-Wall
2001-07-08 21:18:06 +00:00
6734807be7
save_errno in signal handler
2001-01-11 22:07:44 +00:00
d7e32e3ed8
need more size to big_buf for line termination (\r\n).
2000-10-10 12:44:37 +00:00
ff9e617fce
use %s with fprintf
2000-07-06 00:01:45 +00:00
cheloha