1
0
mirror of https://github.com/openbsd/src.git synced 2026-06-18 07:13:36 +02:00

when replying to a "query" SSH_AGENTC_EXTENSION request, don't

append an SSH_AGENT_SUCCESS to the reply to the query. bz3967
ok dtucker@
This commit is contained in:
djm
2026-06-13 00:37:13 +00:00
parent ec77777651
commit 0092726c83
+7 -5
View File
@@ -1,4 +1,4 @@
/* $OpenBSD: ssh-agent.c,v 1.328 2026/05/31 04:31:04 djm Exp $ */
/* $OpenBSD: ssh-agent.c,v 1.329 2026/06/13 00:37:13 djm Exp $ */
/*
* Author: Tatu Ylonen <ylo@cs.hut.fi>
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -1789,7 +1789,7 @@ process_ext_query(SocketEntry *e)
static void
process_extension(SocketEntry *e)
{
int r, success = 0;
int r, replied = 0, success = 0;
char *name;
debug2_f("entering");
@@ -1800,7 +1800,7 @@ process_extension(SocketEntry *e)
}
if (strcmp(name, "query") == 0)
success = process_ext_query(e);
replied = success = process_ext_query(e);
else if (strcmp(name, "session-bind@openssh.com") == 0)
success = process_ext_session_bind(e);
else {
@@ -1811,8 +1811,10 @@ process_extension(SocketEntry *e)
}
free(name);
/* Agent failures are signalled with a different error code */
send_status_generic(e,
success ? SSH_AGENT_SUCCESS : SSH_AGENT_EXTENSION_FAILURE);
if (!replied) {
send_status_generic(e,
success ? SSH_AGENT_SUCCESS : SSH_AGENT_EXTENSION_FAILURE);
}
}
/*