openbsd/src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2026-06-19 15:53:31 +02:00
Code Activity

In wbinvd_on_all_cpus_acked() only request wbinvd from CPUs that

Browse Source 
are actually running, i.e. CPUF_RUNNING is set.

Noted by deraadt@

ok claudio@ bluhm@
This commit is contained in:
hshoexer
2025-09-22 13:19:03 +00:00
parent f8c54f06bd
commit d8b9fe87b4
1 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sys/arch/amd64/amd64/cpu.c
+14 -15
View File
@@ -1,4 +1,4 @@
/* $OpenBSD: cpu.c,v 1.199 2025/09/19 07:00:32 sf Exp $ */
/* $OpenBSD: cpu.c,v 1.200 2025/09/22 13:19:03 hshoexer Exp $ */
/* $NetBSD: cpu.c,v 1.1 2003/04/26 18:39:26 fvdl Exp $ */
/*-
@@ -1487,28 +1487,27 @@ wbinvd_on_all_cpus_acked(void)
int s;
CPU_INFO_FOREACH(cii, ci) {
if (ci == self)
if (ci == self || !(ci->ci_flags & CPUF_RUNNING))
continue;
mask |= (1ULL << ci->ci_cpuid);
wait++;
}
KASSERT(wait > 0);
s = splvm();
while (atomic_cas_ulong(&wbinvd_wait, 0 , wait) != 0) {
while (wbinvd_wait != 0) {
CPU_BUSY_CYCLE();
if (wait > 0) {
s = splvm();
while (atomic_cas_ulong(&wbinvd_wait, 0 , wait) != 0) {
while (wbinvd_wait != 0)
CPU_BUSY_CYCLE();
}
}
CPU_INFO_FOREACH(cii, ci) {
if ((mask & (1ULL << ci->ci_cpuid)) == 0)
continue;
if (x86_fast_ipi(ci, LAPIC_IPI_WBINVD) != 0)
panic("%s: ipi failed", __func__);
CPU_INFO_FOREACH(cii, ci) {
if ((mask & (1ULL << ci->ci_cpuid)) == 0)
continue;
if (x86_fast_ipi(ci, LAPIC_IPI_WBINVD) != 0)
panic("%s: ipi failed", __func__);
}
splx(s);
}
splx(s);
wbinvd();